Update from 0.2.1 to 0.3.0 :out-file is deprecated

Question

Update from 0.2.1 to 0.3.0 :out-file is deprecated

GiovanniFerrari opened this issue 8 years ago · 8 comments

GiovanniFerrari commented 8 years ago

We have a problem switching from version "0.2.1" to version "0.3.0" of boot-cljs-test,

when we replace the option "--out-file" (allowed in "0.2.1" but deprecated in "0.3.0") with "--ids",

as suggested by the test-cljs task.

Old version of the code

Github location: https://github.com/manuTro/cljs-test-problem/tree/old_library_version

New version of the code

Github location: https://github.com/manuTro/cljs-test-problem/tree/new_library_version
Changes with respect to old version:

created folder html/js
created file main.cljs.edn in html/js
in shopping.html, changed javascript file path from main.js to js/main.js
in build.boot, changed test-cljs option ":out-file main.js" to ":ids ["js/main"]"
in build.boot, changed test-cljs option :update-fs? from true to false

Error:

when we run the code, the tests are not executed and we get the following error message:

Testing with Phantom:ClojureScript could not load :main, did you forget to specify :asset-path?

ReferenceError: Can't find variable: goog 
phantomjs://code/phantom4803593222426079124.js:81 in onError

How should we modify the "test-cljs" task options in order to obtain the behaviour we had with the "0.2.1" version of boot-cljs-test?

Answer 1 · 2017-03-04T05:56:38.000Z

Hey @GiovanniFerrari — you could try setting :asset-path in your main.cljs.edn file's compiler options to look like this

{:require [,,,]
 :init-fns [,,,]
 :compiler-options {:asset-path "/js/main.out"}}

If that doesn't work on the spot you can look in the Devtools Network tab to see where your browser is trying to load the files from and try different settings for :asset-path. Also look up the docs for :asset-path to understand how it affects where files are loaded from.

Hope that helps 👍

Answer 2 · 2017-03-04T17:23:25.000Z

Hi Martin!
Thank you for your answer! :) yes, this has helped. I think that the problem is that if I set ":asset-path 'js/main.out' " the html file is able to get the "js/main.js" file and all the goog variables presents in "js/main.out/goog/base.js". But phantomjs is not able to find the same goog variable and it give me the error above (maybe because it is looking for a "js/main.out" folder in "/js" (I guess)). If I use "main.out" as :asset-path, phantomjs find the goog variable but html can't. I resolved placing the html in the "/js" folder, so the ":asseth-path 'main.out' " version were good for both. I don't know if it is a good solution, or even if it is a solution, but for the moment it is working 🤔... I wonder why with the old version there was no need for an .end file, while with the new version there is no solution without it 🤔

Answer 3 · 2017-03-06T20:54:47.000Z

@GiovanniFerrari this looks like a pretty face-palmy bug on my side - asset-path is not being respected properly.

The point of breakage in your upgrade seems to be caused by the decision (led by the "main is a single segment namespace" warning?) to nest the javascript in a js folder. Moving the html inside js is basically equivalent to undoing that change - so undoing is probably simpler 🙂

Another face-palm is that :update-fs? is in opposite-land, it's behaving the opposite way to its description.. and swapping that now will just spread more confusion.. So perhaps fuel for #53 and decomplecting "continue execution" from the main task.

Will publish a version that respects asset-path, and can silence that particular "single segment" too to avoid luring others into relative path rabbit holes 🙂

Answer 4 · 2017-03-08T08:44:46.000Z

Hi Cris!

Thank you for your reply! :) Yes, the source of the nesting is exactly the "main is a single segment namespace".

About the update-fs, ok, in fact in the old version 0.2.1 I settled the parameter to true.

Perfect, we will wait for the new version! ;)

Answer 5 · 2017-03-08T09:44:31.000Z

Managed to get a rough version working.. but it's quick hacky and want to refactor before merging. Will push out an alpha for you to try though :)

Answer 6 · 2017-03-08T09:50:53.000Z

Published 0.3.1-SNAPSHOT

Answer 7 · 2017-03-08T17:31:51.000Z

Yes, it works! Thanks ;) There is still the reverse behaviour of "update-fs" (if I use false I shouldn't have any target directory, right? Now with false I have a target directory). I was wondering if it was possible to avoid to add the .edn file (every time I have to add new namespaces). Was it generated automatically with the old version (0.2.1) of the library? 🤔

Answer 8 · 2017-03-09T02:52:59.000Z

Creating the .edn file is not necessary - it's just a convenient way to configure CLJS compiler options (eg. asset-path here), notably if you're running multiple suites with different options. In your case using :cljs-opts should suffice.

re: update-fs, despite the unfortunate regression I don't want to flip-flop yet another time (for new users or people who adapted to it once) - rather want to extract the pattern to a generic, à la carte task-wrapper.