cristaloleg/go-advice

Separate advices from tricks

Opened this issue · 2 comments

taylankasap commented

Repo name is go advice so I was thinking these are advices. But repo description says advice and tricks.

For example, is this an advice?

  • check interface implementation during compilation
var _ io.Reader = (*MyFastReader)(nil)

Or does it just mean "if you need to check interface implementation during compilation, then do this", if so this makes it a trick, not an advice.

Unfortunately I'm not sure which is which so I can't open a PR. But IMO there should be a separation.

cristaloleg commented

You're too strict to the repo name.

Repo called blabla doesn't mean it's about "bla bla", it might be literally anything. Similar situation with go-advice.

It's not only advices but also a useful patterns that are not so obvious for the new gophers.

I don't think that removing "tricks" from repo description will change something. Curious to hear wdyt. Thx.

taylankasap commented

@cristaloleg sorry I think I wasn't clear. I meant separation in this repo itself, e.g. 2 sections in the readme. Not a separate repo.

I agree with you on repo name not meaning much. But I thought these were all advices until after I read the description. Others might make the same mistake.