critter-mj/akochan

legal chi and dahai judge, may be bug

heartup opened this issue · 1 comments

heartup commented

akochan/share/make_move.cpp

Line 416 in ab83c93

if (haikind(hai) < haikind(consumed0) && haikind(hai) < haikind(consumed1) && haikind(dahai) == haikind(hai) + 2) { return false; }

I think it should be the following:
if (haikind(hai) < haikind(consumed0) && haikind(hai) < haikind(consumed1) && haikind(dahai) == haikind(hai) + 3) { return false; }
if (haikind(hai) > haikind(consumed0) && haikind(hai) > haikind(consumed1) && haikind(dahai) == haikind(hai) - 3) { return false; }

critter-mj commented

Thank you for reporting!
I'm glad to know that the code is checked by other developers.
Now I have fixed this bug.