crossplane-contrib/provider-argocd

Cluster fails to delete

stevendborrelli opened this issue · 0 comments

stevendborrelli commented

What happened?

When deleting clusters, the MR will be deleted, but the Cluster will remain in ArgoCD.

I believe that in the commit below the check if meta.WasDeleted(cr) && meta.GetExternalName(cr) != observedCluster.Name { was converted from !- to ==.

https://github.com/crossplane-contrib/provider-argocd/pull/59/files#diff-6018422a524a37b8b948ecc6863963b91153ca3810461b1868a7b79ea4bd0b09R118

How can we reproduce it?

  • Create Cluster
  • Delete Cluster MR
  • Observe if Cluster exists in the ArgoCD UI