crossplane-contrib/provider-kubernetes

Updates to latest tools broke CRD generation

bobh66 opened this issue · 1 comments

What happened?

The changes in #47 broke the main branch because the CRDs were generated with missing apiVersion attributes

This was caused by the Makefile clean.crds target being called after the generate target because it was configured as generate.done: clean,crds

Since it works in the provider-terraform project with just generate: clean.crds, which means that the CRDs are corrupted and then overwritten, I think the clean.crds target can be removed from the Makefile since whatever it was there for doesn't seem to be a problem anymore.

How can we reproduce it?

Run make generate on the branch from #47 and observe that the generated CRDs are missing the first two lines.

Fixed by #51