croustibat/filament-jobs-monitor

getNavigationGroup

CodeWithDennis opened this issue · 1 comments

Changing group_label in config does not change the group.

Logic looks flawed, the condition is essentially saying if the group_label is set, use the translation, not the config value. If the config key is missing then it's null, which removes the group navigation item.

I understand why it's trying to use the translation, not sure the most appropriate fix knowing the translation value would like to be kept however the translations aren't published.

return config('filament-jobs-monitor.navigation.group_label') ? config('filament-jobs-monitor.navigation.group_label') : null;