256 color terminal support
d11wtq opened this issue · 5 comments
First, I love this theme, so kudos on that. I work in a terminal almost all the time, and unfortunately some of the color choices don't work well in that case here.
I've switched out the colors as closely as a could to get it looking similar in a terminal. Unfortunately that meant sacrificing the nice pastel blue background color and using a more basic grey. I'm just wondering (not even sure if it's possible), would you like me to send you the changes, so perhaps that can be incorporated directly into your own theme and conditionally set based on the environment (Terminal vs GUI), or would you rather a fork exist named subatomic256 or something?
Apologies if you want to cause me harm for butchering your colors to make this work 
Thank you for the kind words!
Yeah, subatomic is not very well suited for terminal use as it is right now. I only load it myself if the window-system variable is non nil. I think what you done looks really cool and would be glad to take a look at the code. I have not really thought of the possibility to have a unified theme for both terminal and non-terminal use, do you know of any themes that does this? Sounds kind of.. awesome... Or perhaps annoying for users that does not expect that behavior of an emacs theme. I don't know :-)
I think I need to sleep on it, but you should go ahead and create the fork! We can always merge later (no homo)! :-p
You're welcome :)
Ok, https://github.com/d11wtq/subatomic256 literally forked and renamed internally so the two can be installed alongside each other. Users could add both and do:
(if (display-graphic-p)
(load-theme 'subatomic t)
(load-theme 'subatomic256 t))However, given the only thing I've really changed is the let with all the colors listed in it, it's trivial to make a unified version that just picks between two color systems, if you decide you want to go that way. Happy to maintain a fork and keep it inline with the original too though.
(defun subatomic-color (full terminal)
(if (display-graphics-p)
full
terminal))
(let ((midnight (subatomic-color "#303347" "#262626"))
( .... ))
... apply faces ...I tried your additions for terminal support and I must say that I quite like it! I also think your implementation is elegant, so if you still want to merge, just send me a pull request! Oh and be sure to add your name as a contributor!
Awesome, thanks! :) I'll send you a PR, but it might not be til early next week as I'm away overseas for a conference at the moment and using my computer infrequently
Sounds great!
Closing the issue and looking forward to it!