[FEATURE REQUEST]: Don't continue on to upgrading AUR packages if repo upgrade fails
orowith2os opened this issue · 10 comments
Describe the bug
Currently, Amethyst will attempt to upgrade its AUR packages if the repo update fails, such as due to a network error. This shouldn't be the case.
To reproduce the bug
Run ame upg without internet access
Amethyst will proceed to fail to upgrade the repo packages, but then ask to try upgrading the AUR packages.
Expected behavior
It should notify the user of a potential network error, and refuse to move onto upgrading the AUR.
Screenshots
Additional context
No response
amethyst should be asking you if you want to continue upgrading aur packages, regardless of if it failed or not, shouldn't that be enough?
It's probably best to not ask to upgrade AUR packages on a network error. It'll be fine normally, but it's not ideal.
well wouldn't the user see that there was a network error and then decline the aur upgrade?
They probably would, but why make a prompt to update the AUR when the repo check failed with a network error?
I wasn't trying to argue against the request, I actually agree with you that the upgrade should fail, I was just explaining what amethyst currently does, sorry if it came over the wrong way
Actually, maybe this would be better fit as a feature request, since it's not really a bug, and more of a design of how Amethyst was made.
The could not resolve host error could be as a result of stale cached DNS, so we can't be sure if it's a user connection error
@not-my-segfault it should still set -e imho tho. If the package manager fails on the safer (non-AUR) upgrades, then something's funky. Not the best time to be doing builds and pacman -U
what do yall think of this?
also i should switch off the i18n branch lol as that got merged