Comfyui Basic Primitive Nodes are Loading with NaN/null whilst having crystools-save enabled

Question

Closed this issue a year ago · 9 comments

Describe the bug
If you load any workflow containing primitive nodes it doesnt load correctly

To Reproduce

Load any Workflow containing a basic primitive Node

Expected behavior
Primitive Node should load correctly

Versions:
v1.10

windows 10 and windows 11

The Workflows with Primitive Node saved using crysstools-save load without a problem on comfyui installations without crystools-save

Answer 1 · 2024-01-18T12:56:35.000Z

I'll check to night; thanks for your feedback
btw, have you updated everything?

Answer 2 · 2024-01-18T21:35:36.000Z

done, can you update and try again please? @barleycoding

Answer 3 · 2024-01-19T07:29:24.000Z

Everything was updated at the time. I just tested after the fix and everything works.
I'll let you know if I discover something else.

Thanks for writing Crystools, it's a great and an essential Add-on to have.

Answer 4 · 2024-01-19T10:32:32.000Z

After some testing , i ran into the same issue .

If a primitive Node is connected with a reroute it brakes again.

Answer 5 · 2024-01-19T10:45:43.000Z

It is so strange. Do you have the latest version?
1.1.3 (on custom_nodes\crystools-save\version)
and remember to push a lot of F5! hehe

Answer 6 · 2024-01-19T11:25:52.000Z

I do have the lastet version.

If i connect a primitive node direclty to the input . it works fine.

Only if theres a reroute node in between the primitive node and the input , than it brakes again.

Answer 7 · 2024-01-19T18:43:47.000Z

Answer 8 · 2024-01-19T19:49:38.000Z

I fixed it. Can you test it (1.1.4), please?
It's a hack. There are race conditions when drawing.
@barleycoding

Answer 9 · 2024-01-20T14:02:19.000Z

I tested 1.1.4
It is fixed.

Ill let you know if i discover something else.