crytic/crytic-compile

Mumbai testnet api not correct

tunabaka opened this issue · 2 comments

tunabaka commented

The api address in the source-code:
image
The api address in mumbai explorer docs:
image
Because of that we can use slither/crytic-compile on mumbai address

elopez commented

Hi! that string then gets included in this string's placeholder, so the API url is generated correctly: https://github.com/crytic/crytic-compile/blob/master/crytic_compile/platform/etherscan.py#L30

I tried analyzing a verified contract from mumbai and it seems to work correctly:

% slither mumbai:0x7a1bac17ccc5b313516c5e16fb24f7659aa5ebed
Installing solc '0.8.6'...
Version '0.8.6' installed.
'solc --standard-json --allow-paths /private/tmp/crytic-export/etherscan-contracts/0x7a1bac17ccc5b313516c5e16fb24f7659aa5ebed-testnet.polygonscan.com-VRFCoordinatorV2' running
INFO:Detectors:
VRFCoordinatorV2.recoverFunds(address) (src/v0.8/dev/VRFCoordinatorV2.sol#337-349) ignores return value by LINK.transfer(to,amount) (src/v0.8/dev/VRFCoordinatorV2.sol#345)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#unchecked-transfer
...

Could you provide more info about the issue you are experiencing? e.g. error messages, failing contract address.

tunabaka commented

My bad. Few days ago i cant use slither on mumbai address, but now it seems to work perfectly
image