cs50/docs

Make no longer gives the "<program> is up to date" message. Specs need to be changed to reflect?

curiouskiwi opened this issue · 4 comments

curiouskiwi commented

In the Find problem, this paragraph no longer fully applies:

The first line tells make that the "target" called generate should be built by invoking the second line’s command. Moreover, that first line tells make that generate is dependent on generate.c, the implication of which is that make will only re-build generate on subsequent runs if that file was modified since make last built generate. Neat time-saving trick, eh? In fact, go ahead and execute the command below again, assuming you haven’t modified generate.c.

 make generate

You should be informed that generate is already up-to-date.

(note that this also applies to the https://cdn.cs50.net/2016/x/psets/3/pset3/pset3.html spec, and has raised questions from edX students).

dmalan commented

Ah, want to submit a PR? We actually tweaked make to forcibly recompile each time, just to avoid this confusion. (And to ward off corner cases where a Makefile doesn't mention some file as a dependency and thus doesn't get rebuilt when it changes.)

curiouskiwi commented

This is still generating questions. Any update?

kzidane commented
dmalan commented

Oops, sorry, looks like we were awaiting a PR. 0:-) Fixed!