Now their darkmode works better...
Closed this issue · 11 comments
Since PM's dark mode seems to now take care of just about everything but HTML rendered emails, have you looked into updating your full modes to support their methodology?
I haven't looked into it yet, is there a setting available to users on settings to toggle dark mode on beta v4? If so, I'll revisit this once I have a spare minute, thank you.
I don't see one on the beta.
Thanks @searsaw, I believe ProtonMail's darkmode is still WIP: ProtonMail/design-system@47b5419
Interesting, even dark composition of messages has been working well for me.
Try using the most recent release of ElectronMail to see if you get it: https://github.com/vladimiry/ElectronMail/releases
This explains it, thanks! It might have been implemented with ElectronMail only in that case.
The themes are developed with ProtonMail releases in mind so I'll look into implementing dark mode when the feature is officially released. 🙏
He's forcing the beta with ElectronMail 4.1+ releases.
Darkmode has been deployed to ProtonMail Beta, I'll be having a look at how it is implemented and make adjustments if needed.
One issue I notice with your "full-version" themes (at least the Green Lume and Vitamin C I've tested) in Beta 4.0 is that the plain-text mail composition box is very dark gray text on an only slightly lighter gray background. Pretty unusable. I've had to hack around it.
Seem great otherwise. Really appreciate your contributions with these since PM has been so slow to deliver usable dark modes.
@seascape thanks for bringing this to my attention, could you provide a screenshot of where this occurs please? This might be best placed on a new issue too. 🙏
@ylluminate after having a look at the official Protonmail Dark Mode I have decided to keep the current implementation used in the themes as is since the PM mode is made through a theme selection instead of being customizable like the custom mode.
I might revisit this in the future as v4.0.x takes shape, but will be closing for now. Feel free to ping me again if there's something that you've seen on PM's dark mode that you would like to see on themes.