csgillespie/efficientR

Suspected typo in Chapter 1

michaelosheaa opened this issue · 6 comments

michaelosheaa commented

I noticed in Line 76 of Chapter 1 the sentence: "It is well known that R code can promote algorithmic efficiency compared with low level languages for certain tasks, especially if the code was written by someone who doesn't fully understand the language."

  • Should this instead be "algorithmic inefficiency"?
Robinlovelace commented

Hi @michaelosheaa yes I think that is a typo! Fix would be most welcome, thanks for pointing this out.

shafayetShafee commented

@Robinlovelace , can I make a pull request to fix this typo 😄?

Robinlovelace commented

Hi @shafayetShafee yes of course, that would be most welcome. Many thanks!

shafayetShafee commented

@Robinlovelace, hey I am noticing that this typo still exists in the online version of the book, although I have corrected it and PR got merged. Did I miss something? Sorry if I did something wrong 😓!

Robinlovelace commented

No that is probably an issue with the build process. Can you help @csgillespie ?

csgillespie commented

This is going to be tricky. It was originally set up via .travis many, many years ago. Converting to GitHub Actions is going to take a little time.