Don’t use parent#push

Question

ai opened this issue 8 years ago · 5 comments

According PostCSS docs, Container#push is low level method and should not be used by plugins.

This method is for parsers only. It doesn’t contains checks as result it is easy to broke AST by putting wrong nodes.

This line produces broken AST, because it doesn’t set a parent property.

@geelen You should replace push() to append().

Here is a issue because of this bug: cssnano/cssnano#163 (comment)

Thanks!

Answer 1 · 2016-04-13T10:58:57.000Z

@geelen what do you think about it?

Answer 2 · 2016-05-11T13:38:38.000Z

Can we get this fixed? 👍

Answer 3 · 2016-05-12T08:35:21.000Z

Fixed at 67ffacf <3

Answer 4 · 2016-05-12T08:35:29.000Z

Published 1.0.1 as well