Latest version seems to no longer emit preceding events at startup

[ahartman]

I rarely restart my Node Red, so I did not notice this issue before.
After a restart the suncron node no longer emits the preceding event.
Also, when using an inject node with 'true' on the suncron node, no output is generated.

The defined crons still fire ok.
After the first cron has fired, an inject node with 'true' produces the expected output.
However, between startup and first programmed cron my flows do no longer work correctly.

Regard, ahartman, Belgium

[csuermann]

May I ask which event was missing? My suspicion is that the event you're expecting simply does not exist for that day, due to the position of the sun with respect to your lat/lon location. Mind you, the node only outputs events for the current day, so if you restart Node-RED in the morning, it would not output e.g. "Night" as a preceding event, even if that was the last event that the node emitted before the restart.

[ahartman]

Dear Cornelius, My flows use ’sunrise’, ‘golden hour’, ’sunset’ and ’nautical dawn’ to define four periods in the day, respectively ’night, ‘dawn,’day’ and ’dusk’. The current period is stored in a global variable and the global context is kept in a file during restarts. So, it is only after a clean restart that you need the emit preceding event at startup; otherwise the period of day will remain undefined until one of my four defined crons fires. I discussed that with you in your issue #3 of 8/11/2019 and you put in the emit checkbox as a result of that discussion. It is only because I migrated my Node-Red system to new hardware that I noticed that nothing is emitted any longer at startup but I am sure that this worked as defined for a long time. I also noticed that an inject node only produces output from the suncron node after the first cron has fired, again on a virgin new installation. Hope this helps. Regards, ahartman, belgium

…

Op 9 dec. 2021, om 14:56 heeft Cornelius Suermann ***@***.***> het volgende geschreven: May I ask which event was missing? My suspicion is that the event you're expecting simply does not exist for that day, due to the position of the sun with respect to your lat/lon location. Mind you, the node only outputs events for the current day, so if you restart Node-RED in the morning, it would not output e.g. "Night" as a preceding event, even if that was the last event that the node emitted before the restart. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFIBPGXH6NIJEA4ZE5EQ7TUQCYQLANCNFSM5JVSG7JQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[csuermann]

Hi @ahartman,

I skimmed the code yet again and still believe the behaviour you're observing must be a logical timing issue. My assumption is that the suncron node will indeed emit the previous event on startup, but only if the startup happens after sunrise (in your case). If you restart Node-RED before sunrise, there wouldn't be a previous sun-event to replay for the current date. Could that be the case?

[ahartman]

Dear Cornelius,
Your assumption is right. After the first cron of the day has fired, in my case 'nautical dawn', your node does emit the previous event at startup. For me, this is no longer very relevant as I have found out how to use contextStorage to the file system. Before that, I would lose the sun position at every restart. That is why I contacted you in 2019 and you out it 'emit preceding event'. With the contextStorage, I will only very rarely need 'emit preceding event' any longer.

Thank you.
ahartman, belgium

[csuermann]

Thanks for confirming, @ahartman!