ImPACT tests failing on main

Question

ImPACT tests failing on main

Closed this issue 6 months ago · 3 comments

Describe the bug
After merging the ImPACT branch, a test of it fails on main (at the moment only on macos, but doesn't look mac specific)

Answer 1 · 2024-04-24T16:29:49.000Z

E.g. here: https://github.com/cta-observatory/ctapipe/actions/runs/8819610819/job/24211266186?pr=2544

Answer 2 · 2024-04-24T16:30:18.000Z

and here: https://github.com/cta-observatory/ctapipe/actions/runs/8819581133/job/24211172507

Answer 3 · 2024-04-25T06:57:35.000Z

Ok, interesting. The easiest thing would be to just raise the tolerance on the assert_allclose a bit. But then when I test it locally the current tolerance is far more than enough, so I wonder what the actual issue is here...