Test data not downloaded

Question

Test data not downloaded

Closed this issue 2 years ago · 4 comments

I noticed that in #33 and #34 tests were not passing, the reason is that it could not download the test data (could not verify the certificate). It seems that in the past days there were changes at PIC. Updating the URL of the files should be enough.

Answer 1 · 2022-01-28T14:23:13.000Z

Apparently not a problem of URL, I contacted Jordi reporting the issue.

Answer 2 · 2022-02-02T16:46:22.000Z

Ah most likely this is because I changed the structure of the MAGICEventSource and MarsCalibratedRun? Actually I removed some functions that are tested in tests/test_magic_event_source.py. If the refactoring is fine for you, I can change the tests script as following the refactored code.

Answer 3 · 2022-02-02T17:28:12.000Z

Hm, I changed the tests script but the situation is same.

Answer 4 · 2022-02-02T17:31:18.000Z

Nope, not a problem related to the changes. If I run the tests offline where I already have the test data downloaded, most of them pass (I run them last week), while here no one is passing. Looking at the log of the workflow which are run automatically when pushing or when creating a PR, the problem is clearly when downloading the data from PIC, which underwent a change in the last week. I wrote Jordi about this, it seems related to certificates, but a simple update of the certificates did not help. I wrote him again on monday, but no reply yet. I tried in different machines, but the problem is the same everywhere. So, let's see if Jordi can somehow solve the problem, what I could do on my side I did :/ of course it is a bummer because automatic tests cannot be run :(