Remove dangerous fall-back to MARS cuts if there is a typo in the config file
Opened this issue · 2 comments
kosack commented
This is a dangerous try/catch here: if anyone mistypes a keyword in the configuration file, all parameters fall back to the MARS defaults silently! There isn't even a warning raised.
protopipe/protopipe/pipeline/event_preparer.py
Lines 224 to 230 in 1f392ea
The expected behavior should be that the analysis simply fails, so the try/catch should be removed.
kosack commented
In fact this seems to be true for all configuration keys.
HealthyPear commented
OK for me: the script could exit with a logging.exception