cta-observatory/pyirf

EventDisplay comparison notebook is included twice

Closed this issue · 4 comments

It is in docs/contributing (where it does not make sense I think) and the notebooks directory

usually I do this so the one in notebooks is an empty one to edit, while the one in the docs is a static copy with the latest results

That's not good! This just duplicates it and makes it hard to maintain. There are better ways to do this.

Like in ctapipe, where the notebooks are included empty in the repository and are executed during the docs build so the output is included in the docs.

I know, but since that is done by the CI pipeline there should be test data stored somewhere, which is not the case now, so that is why I didn't do it

Fixed in #36