draw() in Bernoulli distribution

Question

gdxie1 opened this issue 3 years ago · 5 comments

the line in the draw should change from self.mu.n_ones / (self.mu.n_ones + self.mu.n_zeros) to

(self.mu.n_ones - 1) / (self.mu.n_ones + self.mu.n_zeros -2)

Answer 1 · 2022-03-14T11:56:35.000Z

Should it be?

Answer 2 · 2022-03-14T15:36:33.000Z

when you added the prior distribution, you should -1 and -2. Maybe I am wrong. Thank you anyway, it's a good project.

Answer 3 · 2022-03-19T23:38:23.000Z

Could you specify from which equation in PRML you though it should have -1 and -2?

Answer 4 · 2022-03-20T20:30:35.000Z

Hi, I checked the book and found that you are right. I mistake the MAP of mu as the p(x=1|D) under Bayes. Sorry for this.

Answer 5 · 2022-03-21T06:25:09.000Z

Oh, I see! Yeah, it is confusing that we need them for estimation of mu and not for p(x=1||D).