ctran/annotate_models

Make `with_comment_column` work with `Annotate.set_defaults`

Closed this issue · 7 comments

Adeynack commented

Describe your problem here.

Commands

$ rake annotate_models

Acceptance Criteria

  • "with_comment_column" => "false" appears after "with_comment" => "false" when calling rails generate annotate:install.
  • its setting is read when annotating (right now, setting it to true does not activate the switch and comment column is not rendered).

Related Issues

This was an oversight when implementing #988.

Adeynack commented

@ctran : You can assign me on this. I will work to fix it.

  • 👀1
ctran commented

Thanks

sureshc commented

Any progress on this? We have a few long table column comments and having this option work with .set_defaults would make the annotations more readable. We can't really turn on with_comment because of the formatting.

Adeynack commented

To be 💯 honest, that slipped my mind completely. But I'll resume my effort here, especially if it can make other's life easier! Thanks for the reminder ;-)

  • 🎉1
sureshc commented

To be 💯 honest, that slipped my mind completely. But I'll resume my effort here, especially if it can make other's life easier! Thanks for the reminder ;-)

Thank you so much. We very much appreciate this gem.

Adeynack commented

@sureshc @ctran : If I am not mistaken, #999 should do the trick :-)

Adeynack commented

@ctran : When can we expect a release with this feature added? 😊