ctrlplusb/react-async-component

React 16 Errors

bradennapier opened this issue · 9 comments

bradennapier commented

Just tried an update to React 16 and it would appear an error with async component makes the app fail to load :(

warning.js:36 Warning: Failed child context type: Cannot read property 'asyncComponentsAncestor' of undefined

Says it is only a warning but my app no longer loads at all and this is the only error I can see..

bkniffler commented

I think you forgot to use AsyncProvider on your client bundle.

bradennapier commented

it says not to use that / it is pointless unless you are using SSR which I am not.

bkniffler commented

Did you try using it? When I forgot to add it (I'm using SSR) I had the same issue, after adding it, the issue was gone.

ctrlplusb commented

Damn that may be a bug then

bradennapier commented

Yeah it is just a warning... it is not actually breaking my app - something else was (having any module that forgets to set react as peer dependency will now pretty much break an app with no real reporting).

I fixed this by adding the provider... it seems that react just adds that warning now if it sees any violation of context types.

Not sure what to do in cases like this when the provider is actually optional...

maxmantz commented

Got the same warning and confirm that adding AsyncComponentProvider will fix it.

codeBelt commented

I am using React 16 and not seeing the issue on my repo hapi-react-hot-loader-example. I am using AsyncComponentProvider on both my client-side and ssr code.

ctrlplusb commented

FYI, I have a fix for the warning in progress. 👍

ctrlplusb commented

Fix is queued in master, should be released shortly.