Make Transit Stable Again

[Omarrasheed]

CLEANUP CREW

Lots of work to be done but a lot of it shouldn't be too complex. Let's split up each of these tasks to a PR so that we can avoid as many merge conflicts as possible while others r working.

Before working on a task, please tag yourself at the end of the task description so we're not doing much overlapping work

• [Daniel] Look into removing UnwindAllStopsTVCDelegate
• [Daniel] No clue what these lines are in AllStopsViewController under UITableViewDelegate extension. Pretty sure we can remove them or move them into PlaceTableViewCell. Reference
• Lets just wrap this whole thing in a chained if let so we can safely unwrap section and place (and sortedKeys[indexPath.section]??) and so we don’t have this weird print statement within the guard. Reference
• Can we look into removing this code from HomeMapViewController? We don’t really have a loading state for the map like ever. Reference
• In setting up the InformationTableViewController, we have this random function that changes the text color based on the row & section number but I feel like this should be based on the section name, considering these come from shared constants. This would prob look wack if we decide to change the ordering at some point down the line. Reference
• Our searchViewController also seems pretty jank. Just kinda lookin thru that and seeing
• Arbitrary delay being used in ServiceAlertsViewController??? Reference
• I feel uncomfortable about having this as an attribute of the BusLocation model. If we can move this to a function of a BusLocation instance or even take it out completely that’d be better. Reference
• BusPath object should probably be in views and not in the models folder
• Confused about our LegacyModels.swift file??
• Lots of similarity between WalkPath and BusPath models. Could refactor to just take in an enum type to decide what kinda setup it should go thru cuz there is currently lots of redundant code
• Loader.swift seems useless
• Phrases.swift also seems useless
• Should def rename SearchTableViewHelpers to something more meaningful
• Shared.swift -> SharedUserDefaults
• Seems like were doing some junk constraint setting in DetailIconView. Can look into potential alternatives to this activating/deactivating of constraints as I’d imagine with all the async calls, this could get pretty wack and cause some weird constraint issues
• Replace isEqual calls with == (maintaining behavior under the hood).
• Make Place and other similar data structures structs instead of classes.