Make AST classes more explicitly value objects

Question

Make AST classes more explicitly value objects

Closed this issue 7 years ago · 7 comments

mattwynne commented 9 years ago

Criteria:

immutable
equality comparison works (by location?)

See 2e85fcb#commitcomment-10458359

Answer 1 · 2015-04-01T15:46:15.000Z

See also #84

Answer 2 · 2015-04-01T19:21:22.000Z

this attr_accessor in background.rb should be possible to change to a attr_reader (the attributes are set in the constructor). What about this attr_accessor in doc_string.rb is the file attribute ever used? It is not set in the constructor, and I can remove the line from the file without neither the cucumber-ruby-core test nor the cucumber test fails.

Answer 3 · 2015-04-02T08:13:46.000Z

@brasmusson if you can remove it without breaking tests, I'm happy to rip it out.

Answer 4 · 2015-04-03T18:16:17.000Z

All attr_accessor declarations are removed from the ast classes (044cca8)

Answer 5 · 2017-11-08T09:43:19.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

Answer 6 · 2017-11-15T10:23:05.000Z

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

Answer 7 · 2018-11-15T10:51:35.000Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.