cucumber/docs

Language tabs should be URL-aware

mattwynne opened this issue · 5 comments

mattwynne commented

I want to link someone to the Ruby version of https://cucumber.io/docs/cucumber/state/ but the URL doesn't change when I switch language tabs.

I'd like the language tabs to:

  1. Switch to the appropriate language tab on opening a page if a querystring parameter is present (e.g. ?lang=ruby)
  2. Update the URL if the language tab is changed (could be dynamic or by just hyperlinking to the new URL)

How would we achieve this?

10xtechie commented

@mattwynne, @aurelien-reeves
I would like to take this on. So if it is still relevant, please assign this to me :)

  • 🎉2
mattwynne commented

Yay! thanks @10xtechie yes it's absolutely still relevant!

https://calendly.com/mattwynne if you want to pair.

10xtechie commented

@mattwynne @aurelien-reeves ,
Thanks for assigning this to me! I have created a PR, please take a look.

10xtechie commented

I think the code for the tabs is here: https://github.com/cucumber/docs/blob/main/themes/cucumber-sb/static/js/site.js

@mattwynne ,
You are right, thanks!