cucumber/messages

PHP version doesn't run end-to-end tests since monorepo split

Opened this issue · 4 comments

ciaranmcnulty commented

(spotted in #102)

The PHP implementation used to look at the compatibility-kit folder to get the ndjson example files.

Because of the way this was implemented, a non-existent folder = no source data = skipped tests :/

The Ruby version also uses the CCK to test, but it looks like CCK is published as a bundle and data's sourced from there - the PHP implementation should explicitly download the CCK data and use it for the tests.

ciaranmcnulty commented

@mpkorstanje am I right in thinking the Java version doesn't have any end-to-end tests in this repo? Should we add some?

ciaranmcnulty commented

#110 is related

mpkorstanje commented

Java has end to end tests. But they're intentionally limited to some interesting cases.

https://github.com/cucumber/messages/blob/main/java/src/test/java/io/cucumber/messages/NdjsonSerializationTest.java

ciaranmcnulty commented

OK I'll do some temporary thing to ensure the CCK samples are downloaded during build, then we can remove that if and when #110 happens