cucumber/vscode

No space between step keywords and step text in Korean dialect

Likilee opened this issue ยท 1 comments

๐Ÿ‘“ What did you see?

There is an issue where formatting in documents written in Korean causes the keywords and sentences to have no space between them.

โœ… What did you expect to see?

There should be a normal space between the formatted keywords and the sentences.

๐Ÿ“ฆ Which tool/library version are you using?

Vs-code extension

image

๐Ÿ”ฌ How could we reproduce it?

  1. Write a document(.feature) in Korean. (With #language: ko)
  2. Trigger format.
  3. Observe that there is no space between the formatted keyword and the sentence.

๐Ÿ“š Any additional context?

Before formatting (What I exepected)

image

After formatting

image

Thanks for flagging this @Likilee! This is an issue within the gherkin parser: a trailing space is missing on Korean step keywords. Thus, when the gherkin formatter parses your gherkin into a Cucumber messages format and writes back the changes, the step keywords and step text become joined.

Observe from the linked issue that I have raised a fix on the gherkin parser and we will have to await a release of the gherkin parser, cucumber language service and finally the Cucumber VSCode extension; but know that a fix is on its way!