Fix removed code that should not

Question

Fix removed code that should not

saucisson opened this issue 7 years ago · 3 comments

@mencattini look at 17f9b47, it seems that you removed some of my code, that was about distance between tools. Is it intentional?

Answer 1 · 2018-01-31T15:42:26.000Z

I didn't understand why the performance become so bad (cf : #10). So i tried with old data to test. It was a mistake of my part to push the changes. Sorry.
Do you want i reverse it ?

Answer 2 · 2018-01-31T16:40:18.000Z

No thanks, i will do it myself, and perform the benchmark to see if it changes the results.

Answer 3 · 2018-01-31T20:26:55.000Z

Put back in 673fcc4.
You can get the old behavior with:

./extract.py --distance=0

If no distance is given, then all tools that reach the maximum number of instances are considered in the results.