cul-it/hfs2dfxml

Apparent variances in python3-magic cause script to fail

Opened this issue · 4 comments

dd388 commented

Right now, it appears that the version of python3-magic that BitCurator is preferring is not compatible with the script:

/usr/local/lib/python3.5/dist-packages/magic.py
Generates "module 'magic' has no attribute open"

Though if the following version is installed
/usr/lib/python3/dist-packages/magic.py

The script will work. More investigation needed... (more soon!)

Thanks to Jessica Venlet (@jesmven) for reporting.

dd388 commented

Python magic is kind of all over the place, so I'm changing this to an improvement task to make the "magic" requirement more precise and formalized in the code.

dd388 commented

Default to magic that installs with pip3 install python-magic; fallback for the other magic (what the code was previously relying on).

https://github.com/cul-it/hfs2dfxml/tree/magic

dd388 commented

@jesmven, can you test this?

dd388 commented

Tested in one case; leaving it open for a while to let others test it.