missing import statements in model.py
Closed this issue · 3 comments
anilbey commented
Hello @cumbof ,
Running static code analysis detected missing import statements in the following functions: Model::auto_tune
, Model::stepwise_regression
and Model::cross_val_predict
.
> ruff . --ignore=E501
hdlib/model.py:672:18: F821 Undefined name `os`
hdlib/model.py:785:18: F821 Undefined name `os`
hdlib/model.py:994:18: F821 Undefined name `os`
Could you make sure the tests in the test module are covering these 3 functions? Thanks
This issue is part of the openjournals/joss-reviews#5704 review.
cumbof commented
Hi @anilbey, thanks for pointing this out.
I fixed the missing import in hdlib.model
and I will add a few additional unit tests ASAP.
I'll keep you updated here. Thanks