Enforce internal max code length

Question

Enforce internal max code length

zongweil opened this issue 6 years ago · 5 comments

Hello!

I'm one of the OLC maintainers and we are in the process of updating all the implementations to limit the number of digits processed to avoid underflow errors. Take a look at google/open-location-code#190 for more details and examples.

Is this something you would be able to take care of for your implementation?

Answer 1 · 2018-10-18T21:04:41.000Z

Yes. Will do right now. Also, will update the project to swift 4.2. I've been meaning to.

Answer 2 · 2018-10-26T16:58:52.000Z

Thanks for the quick action! I added a couple of comments on your commit - happy to continue the discussion.

Answer 3 · 2018-10-28T05:51:14.000Z

Should be complete in 0.5.5 (including the comment changes :-) )

Answer 4 · 2018-10-28T23:13:38.000Z

Thanks! :)

Answer 5 · 2018-11-29T16:05:10.000Z

This is fixed here ccc5a0a and already released