curbmap/OpenLocationCode-swift

Floating point precision issues for Swift

Opened this issue · 2 comments

zongweil commented

Hello from the main Open Location Code repo!

We're currently working on fixing floating point precision issues with the various implementations (see here). For the implementations not directly in the main repo, we're asking for the owners to update their code accordingly. Would you be able to do the following when you get a chance?

  1. Run the new test cases in test_data/encoding.csv.
  2. If they fail, fix your implementation to properly handle the floating point precision issues. I'll post again when we have a commit that you can use for reference.
eselkin commented

I'll take a look. I imagine if the others fail, so will this since it's very closely tied to the algorithms in the other libraries.

eselkin commented

I'm going to make all test cases run from the test_data directory... if any fail then I'll identify that in the README as well.