custom-components/breaking_changes

Loaded components are ignored

springstan opened this issue · 6 comments

arch armv7l
dev false
docker true
hassio true
os_name Linux
python_version 3.7.6
version 0.103.6
virtualenv false

Version of the custom_component

3.6

Describe the bug

A clear and concise description of what the bug is.

  • all breaking changes are loaded instead of only loading the breaking changes that are based on the loaded components

custom_updater configuration

breaking_changes:

Debug log

DEBUG (MainThread) [custom_components.breaking_changes] Loaded components [all my components...]
stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

This is still an issue.

It looks like this may be an issue with how https://hachanges.halfdecent.io/ is scraping the release notes. Every breaking change has component as null and doclink as "https://www.home-assistant.io/components/None" which is causing it to treat them as being related to the homeassistant component which would always be loaded.

@gadgetchnnel good catch! Did not inspect https://hachanges.halfdecent.io/ at all but your explanation makes a lot of sense to me.

afaict this is because components were renamed to integrations. I've submitted a merge request here which I hope will fix that in the code checking for breaking changes: ludeeus/furystoolbox#1

The new website is live with correct integration names https://hachanges.halfdecent.io/105