cutenode/good-first-issue

Long title messes the UI

ItamarShDev opened this issue · 4 comments

bnb commented

Yup, I've seen this before. It really depends on the width of your terminal. We could theoretically split up the title if it exceeds a certain number of characters 🤔

ItamarShDev commented

I can apply the fix, once I'll know what the decided fix is :)

bnb commented

@ItamarShDev feel free to take a stab at whatever you think would work! My thoughts:

  • We add custom padding + a string that total 19 characters when the title is the longest line (see this screenshot)
  • I would suggest we use 80 characters as a good place to cap
  • 80 - 19 = 61

Suggestion:

  • If a title exceeds 61 characters, split it at the (space) before the 69th character
  • Start the rest of the title on the same character as the first letter of the rest of the title so they are aligned (I believe this will always be character 16, but keep in mind 4 characters that are added by Boxen)
DanielRuf commented

Hm, why not use cli-table3? Or we should report this in the boxen repo.