Support ">" in image_aspect
Closed this issue · 4 comments
johnlui commented
/vendor/cviebrock/image-validator/src/ImageValidator.php
line 118:
// JohnLui 2015-11-12 15:33:43
// support ">" in image_aspect
if (substr($parameters[0],0,1)=='>') {
if ( bccomp(substr($parameters[0], 1), $image_aspect, 10) == -1 ) {
return true;
}
}
johnlui commented
support "<":
if (substr($parameters[0],0,1)=='<') {
if ( bccomp(substr($parameters[0], 1), $image_aspect, 10) == 1 ) {
return true;
}
}
cviebrock commented
Can you make a PR with those? Add some tests and update the readme with how one would use them, and I'll merge it in.
Thanks!
johnlui commented
Thanks for your awesome project!
I will do it when I have the time.
From My iPhone
在 2015年11月12日,23:26,Colin Viebrock notifications@github.com 写道:
Can you make a PR with those? Add some tests and update the readme with how one would use them, and I'll merge it in.
Thanks!
—
Reply to this email directly or view it on GitHub.
cviebrock commented
I guess you haven't had the time. 😞 Re-open or submit a PR when you can.