Add data structure callback observers

Question

Add data structure callback observers

Closed this issue 4 years ago · 8 comments

As mentioned in #188, I developed an observer system to be notified by callback by pjs when the datastructure changes.

The code is currently meant to be loaded externally and thus uses monkey-patching to hook up with pjs. I also wrote some unittests showing how to use the patch.

In case you find this system useful, I could create a merge request and incorporate the code directly into the source code of pjs.

Answer 1 · 2020-02-08T12:01:50.000Z

(Just a reminder to myself when I'll implement the observer directly in the library.)
I just noticed that the test for arrays in ProtocolBase.validate does not check for ArrayWrapper neither and should be expanded to make the observers survive. Additionally, the _parent links need to be rewired in ArrayWrapper.__init__.

Answer 2 · 2020-03-02T18:36:12.000Z

So, what do you think? Should we make this an official part of pjs?

Answer 3 · 2020-04-04T14:33:18.000Z

@st31ny I couldn't find anything at those gist links above? I get a 404

Answer 4 · 2020-04-04T14:44:18.000Z

Oh, I updated the links. I had changed my username and the old links became invalid.

Answer 5 · 2020-06-04T00:17:31.000Z

Stale issue message

Answer 6 · 2020-06-15T10:47:19.000Z

Have you found some time to consider the changes?

Answer 7 · 2020-06-15T12:30:48.000Z

Sorry, no, but let me reopen it - didn’t catch the rampaging stalebot in time.

…

On Jun 15, 2020, at 6:47 AM, Maximilian Stein ***@***.***> wrote: Have you found some time to consider the changes? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 8 · 2020-06-23T14:43:46.000Z

this bot is quite bold