cweckerl/simplefarming

Harvest With Ease compatibility

Opened this issue · 1 comments

Hi, lately an issue was opened on my mod Harvest With Ease.
Harvest With Ease is a widespread mod to right-click harvest crops.
Unfortunately, Simple Farming tall crops (2-block high crops) don't work well with it.

I managed to pinpoint the source of the problem:
Simple Farming tall crops are not two blocks of the same kind one above the other, but are two different blocks, with the top one not being a crop (does not extend CropBlock and is not in the crops taglist) and not having the AGE property.
Unfortunately, I can't just hardcode custom solutions for every mod, otherwise HWE would lose in generalization and it would potentially mean a huge workload (I'm 1, I can't hardcode solutions for 100 mods).
The idea would be that, if I see there's a bug or an oversight on my part, I'd fix it and improve generalization, otherwise it'd be up to the other mods to adapt themselves (so that 1 modder/team, 1 fix each).

To fix this, I can think of 3 different solutions on your side (in order of what I think would be the best):

  1. Change how your tall crop classes work to resemble more how it's done with Supplementaries Flax and Immersive Engineering Hemp.
  2. Add HWE as optional dependency in your project and use the provided API to hook in the events and change the harvest behavior for your tall crops.
  3. Change your top and bottom classes such that the top is a proper crop and that each half, when Level#setBlockAndUpdate is called, they destroy the other half (this should work in theory, I'm not 100% sure tho).

I hope to have helped, let me know if you have any question or something's not clear!

Hi! It's been over a year without any update. If you'd like, I'd be available to help with any of the solutions proposed.