cxreg/smartcd

Export is broken for more than just one directory

frioux opened this issue · 3 comments

Ok, this is really easy to produce, but beyond me to figure out what's wrong. This works to repro bug:

 rm ~/.smartcd* -rf
 rm ~/.zshrc
 touch ~/.zshrc
 # choose defaults
 curl -L http://smartcd.org/install | bash
 source ~/.zshrc
 cd ~
 echo "echo 1" | smartcd edit enter
 cd ~/tmp
 echo "echo 1" | smartcd edit enter
 smartcd export

The basic problem here is the for loop isn't splitting on newlines when looping at lib/core/smartcd_export line 21. I'm not really clear why ls is being used to get a file list instead of just using globbing, so I won't suggest a fix.

I believe I have a working solution on https://github.com/cxreg/smartcd/tree/test_fix_bug_17. The reason ls was being used was just laziness, and it was a mistake. Let me know if this resolves your issue

Fixed in 0c9010a