cyamato/SyslogPro

Incorrect Timestamp conversion for "RFC5424"

Opened this issue · 0 comments

Describe the bug
SyslogPro RFC5424 is using moment for time formatting but in the format strings, the hour formatting is given as 'hh' not 'HH' which results in 12-hour time formatting. In this way. an event happened at 00:12:23 will be formatted to 12:12:23. This is error-prone. Therefore please change the formatting strings

To Reproduce
Steps to reproduce the behavior:
Look at '// RFC5424 timestamp formating' section in code (index.js)

Expected behavior
Timestamp formatting in RFC5424 to support 24 hour support

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Node
  • Version 11.15