cyb3rko/pincredible

Improve save dialog

johnjohndoe opened this issue · 4 comments

johnjohndoe commented

I noticed the following issues:

  • closes on rotation
  • does not respect the character limit
  • does not show an error message on reaching the character limit
cyb3rko commented

Thank you for your feedback.

Which save dialog are you referring to?
The password input dialog for backups or the dialog when saving the PIN table as image?

johnjohndoe commented

I was referring to the "Save PIN" dialog but it is probably good to check all dialogs.

cyb3rko commented

Which version did you use?

Because for me it works as expected and as defined by Material 3 (using Version 0.4.1):

When typing and exceeding the limit the box and character limit color turns red.

If I click on "Save" an additional error message is shown.

johnjohndoe commented

Ah. My expectation would be that characters more than 30 are not accepted and the error shows up immediately when I type 30+ characters.