Consider deprecating `#signed_token`
Opened this issue · 2 comments
micahlee commented
It's unclear what purpose Key#signed_token
serves. It does not produce a valid JWT token, and the only apparent uses of this method are in tests for slosilo
and cyberark/conjur
.
This is potentially a good candidate for removal to simply the code and reduce the opportunity for mistakes using this library.
Lines 73 to 79 in c2bb674
dividedmind commented
FWIW it's a legacy token format I invented before JWT was a thing and AFAIR it was kept for compatibility. IMHO it can go.
micahlee commented
FWIW it's a legacy token format I invented before JWT was a thing and AFAIR it was kept for compatibility. IMHO it can go.
Ah, that's really helpful to know. Thanks so much! 🙂
P.S. I hope you're doing well!