binlog can be disabled
shunki-fujita opened this issue · 0 comments
shunki-fujita commented
Describe the bug
There is code that tries to disable binlog.
Line 168 in a7352fa
However, this variable is the filename of binlog and does not disable binlog.
https://dev.mysql.com/doc/refman/8.0/en/replication-options-binary-log.html#option_mysqld_log-bin
To disable binlog, either skip-log-bin or disable-log-bin must be specified.
Thus, delete() here is not working as intended.
Expected behavior
Specifying skip-log-bin or disable-log-bin does not disable binlog