cyclejs/todomvc-cycle

Alternative for route handling?

dfernandez79 opened this issue · 2 comments

dfernandez79 commented

This line in src/intents/todos.js:

changeRoute$: Rx.Observable.fromEvent(window, 'hashchange')

breaks the concept of response observables comming from the user, I think that the hashchange event should come from the domDriver or other driver. It also makes testing hard, and adds a global reference that is not declared.

staltz commented

You are right and it needs to be fixed.

staltz commented

Fixed with a very lightweight driver.