cynthiahqy/conformr-xmap-project

Refactor function to be consistent with naming convention / API design

Closed this issue · 1 comments

cynthiahqy commented

Related to naming conventions in recorded in create-xmap.Rmd

  • rename .get_xmap_subclass() fnc?
  • rename has_ to vhas_* to remind me of vector inputs
  • rename links_from_list() to `pairs_from_list() #66

Related to #82 refactor of construction and validation fncs:

  • rename validate_links_as_xmap() to verify_???
  • refactor validate_xmap_df() and as_xmap_df() to do minimal checks and redirect to verify_links_as_xmap()

Related to #88 special cases of xmaps and #70 describing xmaps:

  • add xmap_has() and xmap_is() fncs as necessary
  • using .calc_* helpers as needed
  • add verify_xmap_as*()-- maybe using compound checking fncs removed in cynthiahqy/conformr-project@90a3b77
cynthiahqy commented

basically done by #121 and outstanding tasks are tracked in other issues