cypress-io/cypress-documentation

Outdated references to `x-cypress-matched-blacklisted-host`

MikeMcC399 opened this issue · 2 comments

MikeMcC399 commented

Subject

Configuration > blockHosts

Description

docs-blockHosts

docs-legacy-blockHosts

both show an outdated screen shot blocked-host.png

the header shows the outdated text x-cypress-matched-blacklisted-host

This was changed in Cypress 5.0.0 through PR cypress-io/cypress#7622 from x-cypress-matched-blacklisted-host to x-cypress-matched-blocked-host (defined in
https://github.com/cypress-io/cypress/blob/65cb16f900cc85175ad17859e8bee2a3b28ba044/packages/proxy/lib/http/request-middleware.ts#L334).

Suggestion

  1. Replace screenshot https://github.com/cypress-io/cypress-documentation/blob/main/static/img/guides/references/v10/blocked-host.png with a new one showing both 503 Service Unavailable and the correct x-cypress-matched-blocked-host text which matches the example using blockHosts:
www.google-analytics.com
*.google-analytics.com
*google-analytics.com

blocked-host

  1. Correct text in References > Configuration > Notes > blockHosts to refer to x-cypress-matched-blocked-host
MikeMcC399 commented

I plan to pick this up and submit a PR to correct this issue.

  • 🎉1
MikeMcC399 commented