How to pass conditional --record CLI flag
bahmutov opened this issue · 4 comments
bahmutov commented
- based on
record
parameter? - and it would be nice to check if the environment variable
CYPRESS_RECORD_KEY
is present too maybe
bahmutov commented
brian-mann commented
I don't think we want to conditionally turn off recording if CYPRESS_RECORD_KEY
is not present. The test runner already checks for this (based on whether or not its a fork) and will no longer error when that key is not present.
If you added this, then people forgetting to pass this value would not record and likely may not notice it until its too late. It should error if CYPRESS_RECORD_KEY
is not present.
bahmutov commented
Sure
…Sent from my iPhone
On Oct 28, 2018, at 21:15, Brian Mann ***@***.***> wrote:
I don't think we want to conditionally turn off recording if CYPRESS_RECORD_KEY is not present. The test runner already checks for this (based on whether or not its a fork) and will no longer error when that key is not present.
If you added this, then people forgetting to pass this value would not record and likely may not notice it until its too late. It should error if CYPRESS_RECORD_KEY is not present.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.