MQTT Discovery support
Closed this issue · 8 comments
I've added the MQTT Discovery function that auto create the components in Home Assistant.
1 - We need to add this to DataLogger.py (for some reason i cant paste the code here it's broke the editor)
2 - some changes need to be done on log_mqtt function still in DataLogger.py
3 - We need to create the call for the new function on example.py or whathever you are using to start the renogy
4 - We neet to indicate in the config.ini the instance name of our home assistant
A video fo the thing working:
https://github.com/cyrils/renogy-bt/assets/148077119/13f61b24-5d9e-4b15-a75d-4f838eb8766e
Another improvment, now it's return the device class and the unit of measurement of the components by Home Assistant MQTT Discovery so the sensor is correctly registred.
Was necessary to change a bit the data structure but i dont think that it can do something bad
Some changes in DataLogger.py and RoverClient.py
Instead of the zip file can you create a PR against branch mqtt-discovery?
I'm not famillyar with githut plataform but i cant try. I ll find some tutorial teaching how to do it.
Instead of the zip file can you create a PR against branch mqtt-discovery?
Ok, i think i did it, my first time using github to update a repository but i guess i did it rigth.
Ah ok. Thanks for the PR, I bet you learned a thing or two today. 😊
@cyrils This was marked as completed however never merged. Do you mind digging back into that branch and merging at some point?
@cyrils @FrancineMatos Whoops, I tried that branch and found a syntax error in one of the files; part of one of the lines was clipped and a > put in instead. I'll see if I can fork that, modify, and submit an MR for that branch to at least make the file workable so it can be merged successfully.
Edit: Branched, Fixed, Merged, PR submitted. Code changes tested successfully, they populate just fine in HA automatically on my HA instance.
@cyrils @FrancineMatos Whoops, I tried that branch and found a syntax error in one of the files; part of one of the lines was clipped and a > put in instead. I'll see if I can fork that, modify, and submit an MR for that branch to at least make the file workable so it can be merged successfully.
Edit: Branched, Fixed, Merged, PR submitted. Code changes tested successfully, they populate just fine in HA automatically on my HA instance.
Hii, nice that worked for you, it's already branched in main->mqtt-discovery, i think there is working fine.