cztomczak/phpdesktop

shadow variable

maddin200 opened this issue · 1 comments

maddin200 commented

/src/cef/client_handler.cpp line 142

BrowserWindow* phpBrowser = GetBrowserWindow(cefHandle);
if (phpBrowser) {
// This block of code gets called for Main window & Devtools window.
ASSERT(!phpBrowser->GetCefBrowser().get());
if (!phpBrowser->GetCefBrowser().get()) {
LOG_DEBUG << "SetCefBrowser() called in "
"ClientHandler::OnAfterCreated()";
phpBrowser->SetCefBrowser(cefBrowser);
}
} else {
// CEF popup browser.
BrowserWindow* phpBrowser = new BrowserWindow(cefHandle, true); // <-- shadow
StoreBrowserWindow(cefHandle, phpBrowser);

cztomczak commented

I don't see a problem.