tell blue from green in pair diagrams
Closed this issue · 6 comments
Very hard for people to tell blue from green in pair diagrams.
4th bullet of https://groups.io/g/GroundForge/message/364,
see also note on color blinds in #197
Related code below. It looks like it only needs a change of the hexadecimal values in the first cited code section and compile it with one of the toJS
scripts.
Side note: The code would more stable if availableColors
was assigned from colors.keys.filterNot(_.isEmpty)
GroundForge/src/main/scala/dibl/Stitches.scala
Lines 149 to 157 in 8be8df1
GroundForge/src/main/scala/dibl/DiagramSvg.scala
Lines 101 to 114 in 3a3d93b
See also the proposed incomplete set of colors: https://github.com/d-bl/GroundForge#colors
A generated color scheme has a mismatch between turquoise and orange. According to the generator it is not color blind safe either. Looking at the diagrams meant for captions in #205 it is still hard to tell blue from green. Any opinions/suggestions?
From https://colorbrewer2.org/#type=qualitative&scheme=Set1&n=7
['#e41a1c','#377eb8','#4daf4a','#984ea3','#ff7f00','#ffff33','#a65628']
GroundForge/src/test/scala/dibl/StitchesSpec.scala
Lines 28 to 54 in da16538
Obsolete due to the new 4-color per stitch approach. Except for the droste pair diagrams, but these are only kept alive on an as-is basis.