d-exclaimation/pioneer

AbortError headers are ignored

Closed this issue · 2 comments

d-exclaimation commented

Describe the bug
When an AbortError is thrown at any point of the code the headers values are always ignored, and thus meant nothing.

To Reproduce
Steps to reproduce the behavior:

  1. Create any Schema
  2. Create a context builder that always throws an Abort or any AbortError with some headers
  3. Create and Run Pioneer GraphQL server
  4. Query any field so the context builder is executed
  5. See that no new headers are set in the response

Expected behavior
Expected that the headers is set to the response headers.

Desktop (please complete the following information):

  • OS: macOS v12 or up
  • Version 0.8.6
  • Any Pioneer configuration
d-exclaimation commented

Planning to patch this soon, but waiting for validation rules (GraphQLSwift/GraphQL#99) and the fixed ConcurrentEventStream
(GraphQLSwift/GraphQL#102) PRs to be merged and a new version of GraphQLSwift/GraphQL to be released.

NeedleInAJayStack commented

@d-exclaimation Cool, those MRs have been merged and tagged! Thanks for contributing!

  • 😄1